Public Member Functions
bool	add (qint32 index)

void	clear ()

	Data ()

bool	isEmpty ()

qint32	max ()

qint32	min ()

bool	remove (qint32 index)

void	replace (const QVector< qint32 > &indexes)

	~Data ()

Public Attributes
QReadWriteLock	m_extentLock

Private Member Functions
void	migrate (qint32 index)

void	unsafeAdd (qint32 index)

void	unsafeMigrate (qint32 index)

void	updateMax ()

void	updateMin ()

Private Attributes
QAtomicInt *	m_buffer

qint32	m_capacity

qint32	m_count

qint32	m_max

QReadWriteLock	m_migrationLock

qint32	m_min

qint32	m_offset

Detailed Description

Definition at line 21 of file KisTiledExtentManager.h.

Constructor & Destructor Documentation

◆ Data()

KisTiledExtentManager::Data::Data ( )

Definition at line 16 of file KisTiledExtentManager.cpp.

    : m_min(qint32_MAX), m_max(qint32_MIN), m_count(0)
{
    QWriteLocker lock(&m_migrationLock);
    m_capacity = InitialBufferSize;
    m_offset = 1;
    m_buffer = new QAtomicInt[m_capacity];
}

References KisTiledExtentManager::InitialBufferSize, m_buffer, m_capacity, m_migrationLock, and m_offset.

◆ ~Data()

KisTiledExtentManager::Data::~Data ( )

Definition at line 25 of file KisTiledExtentManager.cpp.

{
    QWriteLocker lock(&m_migrationLock);
    delete[] m_buffer;
}

Member Function Documentation

◆ add()

bool KisTiledExtentManager::Data::add ( qint32 index )

Definition at line 31 of file KisTiledExtentManager.cpp.

{
    QReadLocker lock(&m_migrationLock);
    qint32 currentIndex = m_offset + index;
 
    if (currentIndex < 0 || currentIndex >= m_capacity) {
        lock.unlock();
        migrate(index);
        lock.relock();
        currentIndex = m_offset + index;
    }
 
    KIS_ASSERT_RECOVER_NOOP(m_buffer[currentIndex].loadAcquire() >= 0);
    bool needsUpdateExtent = false;
 
    while (true) {
        QReadLocker rl(&m_extentLock);
 
        int oldValue = m_buffer[currentIndex].loadAcquire();
        if (oldValue == 0) {
            rl.unlock();
            QWriteLocker wl(&m_extentLock);
 
            if ((oldValue = m_buffer[currentIndex].loadAcquire()) == 0) {
 
                if (m_min > index) m_min = index;
                if (m_max < index) m_max = index;
 
                ++m_count;
                needsUpdateExtent = true;
 
                m_buffer[currentIndex].storeRelease(1);
            } else {
                m_buffer[currentIndex].storeRelease(oldValue + 1);
            }
 
            break;
        } else if (m_buffer[currentIndex].testAndSetOrdered(oldValue, oldValue + 1)) {
            break;
        }
    }
 
    return needsUpdateExtent;
}

References KIS_ASSERT_RECOVER_NOOP, and KisTiledExtentManager::m_extentLock.

◆ clear()

void KisTiledExtentManager::Data::clear ( )

Definition at line 130 of file KisTiledExtentManager.cpp.

{
    QWriteLocker lock(&m_migrationLock);
    QWriteLocker l(&m_extentLock);
 
    for (qint32 i = 0; i < m_capacity; ++i) {
        m_buffer[i].storeRelaxed(0);
    }
 
    m_min = qint32_MAX;
    m_max = qint32_MIN;
    m_count = 0;
}

References KisTiledExtentManager::m_extentLock, qint32_MAX, and qint32_MIN.

◆ isEmpty()

bool KisTiledExtentManager::Data::isEmpty ( )

Definition at line 144 of file KisTiledExtentManager.cpp.

{
    return m_count == 0;
}

◆ max()

qint32 KisTiledExtentManager::Data::max ( )

Definition at line 154 of file KisTiledExtentManager.cpp.

{
    return m_max;
}

◆ migrate()

void KisTiledExtentManager::Data::migrate ( qint32 index )

inlineprivate

Definition at line 203 of file KisTiledExtentManager.cpp.

{
    QWriteLocker lock(&m_migrationLock);
    unsafeMigrate(index);
}

◆ min()

qint32 KisTiledExtentManager::Data::min ( )

Definition at line 149 of file KisTiledExtentManager.cpp.

{
    return m_min;
}

◆ remove()

bool KisTiledExtentManager::Data::remove ( qint32 index )

That is not the droid you're looking for. If you see this assert in the backtrace, most probably, the bug is not here. The crash happens because two threads are trying to do device->clear(rc) concurrently for the overlapping rects. That is, they are trying to remove the same tile. Look higher!

Definition at line 76 of file KisTiledExtentManager.cpp.

{
    QReadLocker lock(&m_migrationLock);
    qint32 currentIndex = m_offset + index;
 
    bool needsUpdateExtent = false;
    QReadLocker rl(&m_extentLock);
 
    const int oldValue = m_buffer[currentIndex].fetchAndAddAcquire(-1);
 
    KIS_SAFE_ASSERT_RECOVER(oldValue > 0) {
        m_buffer[currentIndex].storeRelaxed(0);
        return false;
    }
 
    if (oldValue == 1) {
        rl.unlock();
        QWriteLocker wl(&m_extentLock);
 
        if (m_min == index) updateMin();
        if (m_max == index) updateMax();
 
        --m_count;
        needsUpdateExtent = true;
    }
 
    return needsUpdateExtent;
}

References KIS_SAFE_ASSERT_RECOVER, and KisTiledExtentManager::m_extentLock.

◆ replace()

void KisTiledExtentManager::Data::replace ( const QVector< qint32 > & indexes )

Definition at line 112 of file KisTiledExtentManager.cpp.

{
    QWriteLocker lock(&m_migrationLock);
    QWriteLocker l(&m_extentLock);
 
    for (qint32 i = 0; i < m_capacity; ++i) {
        m_buffer[i].storeRelaxed(0);
    }
 
    m_min = qint32_MAX;
    m_max = qint32_MIN;
    m_count = 0;
 
    Q_FOREACH (const qint32 index, indexes) {
        unsafeAdd(index);
    }
}

References KisTiledExtentManager::m_extentLock, qint32_MAX, and qint32_MIN.

◆ unsafeAdd()

void KisTiledExtentManager::Data::unsafeAdd ( qint32 index )

inlineprivate

Definition at line 159 of file KisTiledExtentManager.cpp.

{
    qint32 currentIndex = m_offset + index;
 
    if (currentIndex < 0 || currentIndex >= m_capacity) {
        unsafeMigrate(index);
        currentIndex = m_offset + index;
    }
 
    if (!m_buffer[currentIndex].fetchAndAddRelaxed(1)) {
        if (m_min > index) m_min = index;
        if (m_max < index) m_max = index;
        ++m_count;
    }
}

◆ unsafeMigrate()

void KisTiledExtentManager::Data::unsafeMigrate ( qint32 index )

inlineprivate

Definition at line 175 of file KisTiledExtentManager.cpp.

{
    qint32 oldCapacity = m_capacity;
    qint32 oldOffset = m_offset;
    qint32 currentIndex = m_offset + index;
 
    while (currentIndex < 0 || currentIndex >= m_capacity) {
        m_capacity <<= 1;
 
        if (currentIndex < 0) {
            m_offset <<= 1;
            currentIndex = m_offset + index;
        }
    }
 
    if (m_capacity != oldCapacity) {
        QAtomicInt *newBuffer = new QAtomicInt[m_capacity];
        qint32 start = m_offset - oldOffset;
 
        for (qint32 i = 0; i < oldCapacity; ++i) {
            newBuffer[start + i].storeRelaxed(m_buffer[i].loadRelaxed());
        }
 
        delete[] m_buffer;
        m_buffer = newBuffer;
    }
}

◆ updateMax()

void KisTiledExtentManager::Data::updateMax ( )

inlineprivate

Definition at line 227 of file KisTiledExtentManager.cpp.

{
    KIS_SAFE_ASSERT_RECOVER_NOOP(m_min != qint32_MIN);
 
    qint32 start = m_max + m_offset;
 
    for (qint32 i = start; i >= 0; --i) {
        qint32 current = m_buffer[i].loadRelaxed();
 
        if (current > 0) {
            m_max = i - m_offset;
            return;
        }
    }
 
    m_max = qint32_MIN;
}

References KIS_SAFE_ASSERT_RECOVER_NOOP, and qint32_MIN.

◆ updateMin()

void KisTiledExtentManager::Data::updateMin ( )

inlineprivate

Definition at line 209 of file KisTiledExtentManager.cpp.

{
    KIS_SAFE_ASSERT_RECOVER_NOOP(m_min != qint32_MAX);
 
    qint32 start = m_min + m_offset;
 
    for (qint32 i = start; i < m_capacity; ++i) {
        qint32 current = m_buffer[i].loadRelaxed();
 
        if (current > 0) {
            m_min = i - m_offset;
            return;
        }
    }
 
    m_min = qint32_MAX;
}

References KIS_SAFE_ASSERT_RECOVER_NOOP, and qint32_MAX.

Member Data Documentation

◆ m_buffer

QAtomicInt* KisTiledExtentManager::Data::m_buffer

private

Definition at line 51 of file KisTiledExtentManager.h.

◆ m_capacity

qint32 KisTiledExtentManager::Data::m_capacity

private

Definition at line 49 of file KisTiledExtentManager.h.

◆ m_count

qint32 KisTiledExtentManager::Data::m_count

private

Definition at line 50 of file KisTiledExtentManager.h.

◆ m_extentLock

QReadWriteLock KisTiledExtentManager::Data::m_extentLock

Definition at line 36 of file KisTiledExtentManager.h.

◆ m_max

qint32 KisTiledExtentManager::Data::m_max

private

Definition at line 47 of file KisTiledExtentManager.h.

◆ m_migrationLock

QReadWriteLock KisTiledExtentManager::Data::m_migrationLock

private

Definition at line 52 of file KisTiledExtentManager.h.

◆ m_min

qint32 KisTiledExtentManager::Data::m_min

private

Definition at line 46 of file KisTiledExtentManager.h.

◆ m_offset

qint32 KisTiledExtentManager::Data::m_offset

private

Definition at line 48 of file KisTiledExtentManager.h.

The documentation for this class was generated from the following files:

libs/image/tiles3/KisTiledExtentManager.h
libs/image/tiles3/KisTiledExtentManager.cpp

Public Member Functions

Public Attributes

Private Member Functions

Private Attributes

Detailed Description

Constructor & Destructor Documentation

◆ Data()

◆ ~Data()

Member Function Documentation

◆ add()

◆ clear()

◆ isEmpty()

◆ max()

◆ migrate()

◆ min()

◆ remove()

◆ replace()

◆ unsafeAdd()

◆ unsafeMigrate()

◆ updateMax()

◆ updateMin()

Member Data Documentation

◆ m_buffer

◆ m_capacity

◆ m_count

◆ m_extentLock

◆ m_max

◆ m_migrationLock

◆ m_min

◆ m_offset